Products/FastWave2.0
2
0
Fork 0
Code Issues 8 Pull requests Actions Packages Projects Releases 1 Wiki Activity

Add term support #19

Merged
ThePerfectComputer merged 7 commits from add_term_support into main 2024-12-30 23:10:28 +00:00
Conversation 2 Commits 7 Files changed 17 +618 -11
ThePerfectComputer commented 2024-12-25 00:41:40 +00:00 (Migrated from github.com)
Copy link

FastWave 2.0 now has a built in terminal using Rust Alacritty as the backend.

image
FastWave 2.0 now has a built in terminal using [Rust Alacritty](https://github.com/alacritty/alacritty) as the backend. <img width="988" alt="image" src="https://github.com/user-attachments/assets/1c7ba169-ab1d-4169-808f-8d97a0a3555e" />
ThePerfectComputer commented 2024-12-25 00:44:07 +00:00 (Migrated from github.com)
Copy link

All you need to do is click on Open Terminal in the header bar.

Some Notes:

  1. Neither terminal resize nor cursor highlighting are currently supported. Such support is planned however for future iterations of Fastwave. The alacritty backend supports both, but I'm currently working on an alternative terminal implementation that uses the MoonZoon backend instead of TauriIPC. This alternative terminal implementation would be part of a larger effort to re-write FastWave to use the MoonZoon backend instead of the TauriIPC as well. Such a re-implementation would be easily amenable to self hosted web sessions of FastWave as well.
  2. Partial(damaged screens) and full screen re-draws are supported as demonstrated by functioning interactive execution of Htop and Vim.
All you need to do is click on `Open Terminal` in the header bar. Some Notes: 1. Neither terminal resize nor cursor highlighting are currently supported. Such support is planned however for future iterations of Fastwave. The alacritty backend supports both, but I'm currently working on an alternative terminal implementation that uses the MoonZoon backend instead of TauriIPC. This alternative terminal implementation would be part of a larger effort to re-write FastWave to use the MoonZoon backend instead of the TauriIPC as well. Such a re-implementation would be easily amenable to self hosted web sessions of FastWave as well. 2. Partial(damaged screens) and full screen re-draws are supported as demonstrated by functioning interactive execution of Htop and Vim.
MartinKavik (Migrated from github.com) requested changes 2024-12-25 16:22:55 +00:00
frontend/src/main.rs
MartinKavik (Migrated from github.com) commented 2024-12-25 15:35:47 +00:00
Copy link

remove

remove
frontend/src/main.rs
MartinKavik (Migrated from github.com) commented 2024-12-25 15:37:28 +00:00
Copy link
  • if instead of match
  • then run makers format or cargo fmt --all
- `if` instead of `match` - then run `makers format` or `cargo fmt --all`
frontend/src/term.rs
MartinKavik (Migrated from github.com) commented 2024-12-25 15:41:10 +00:00
Copy link

please add more context so we both know what should be implemented here without trying to read all related code

please add more context so we both know what should be implemented here without trying to read all related code
MartinKavik (Migrated from github.com) commented 2024-12-25 15:55:51 +00:00
Copy link

.chars basically brakes non-ASCII chars. It means when you try to format path like C:\nová složka\můj nový soubor (C:\new folder\my new file in Czech) then if fails. You should be able to use https://crates.io/crates/unicode-segmentation

(only applies if the term can be a user-defined text)

[.chars](https://doc.rust-lang.org/std/primitive.str.html#method.chars) basically brakes non-ASCII chars. It means when you try to format path like `C:\nová složka\můj nový soubor` (`C:\new folder\my new file` in Czech) then if fails. You should be able to use https://crates.io/crates/unicode-segmentation (only applies if the `term` can be a user-defined text)
MartinKavik (Migrated from github.com) commented 2024-12-25 16:12:03 +00:00
Copy link

if .chars().count() is really what you want (see the previous review comment) then you can replace the if's body with something like:

return Some(process_for_ctrl_char(s[0], has_ctrl))
if `.chars().count()` is really what you want (see the previous review comment) then you can replace the `if`'s body with something like: ```rust return Some(process_for_ctrl_char(s[0], has_ctrl)) ```
MartinKavik (Migrated from github.com) commented 2024-12-25 16:18:54 +00:00
Copy link

Perhaps you can use methods like is_ascii_alphabetic or is_ascii_lowercase or even is_ascii_control

Perhaps you can use methods like [is_ascii_alphabetic](https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_alphabetic) or [is_ascii_lowercase](https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_lowercase) or even [is_ascii_control](https://doc.rust-lang.org/std/primitive.char.html#method.is_ascii_control)
frontend/src/term.rs
@ -0,0 +46,4 @@
"Term not yet started!".to_string()
},
TerminalDownMsg::BackendTermStartFailure(msg) => {
format!("Error: BackendTermStartFailure: {}", msg)
MartinKavik (Migrated from github.com) commented 2024-12-25 15:39:05 +00:00
Copy link
                            format!("Error: BackendTermStartFailure: {msg}")
```suggestion format!("Error: BackendTermStartFailure: {msg}") ```
frontend/src/term.rs
@ -0,0 +62,4 @@
}
fn send_char(
s : &str,
MartinKavik (Migrated from github.com) commented 2024-12-25 15:58:11 +00:00
Copy link

can we use c: char instead? Ideally everywhere where it makes sense instead of String allocation and passing strings in the methods called send_char.

can we use `c: char` instead? Ideally everywhere where it makes sense instead of String allocation and passing strings in the methods called `send_char`.
frontend/src/term.rs
@ -0,0 +66,4 @@
has_control : bool,
) {
match process_str(s, has_control) {
Some(c) => {
MartinKavik (Migrated from github.com) commented 2024-12-25 16:01:04 +00:00
Copy link

Replace match + Some with if let Some... (https://doc.rust-lang.org/rust-by-example/flow_control/if_let.html)

Replace `match` + `Some` with `if let Some...` (https://doc.rust-lang.org/rust-by-example/flow_control/if_let.html)
src-tauri/src/lib.rs
MartinKavik (Migrated from github.com) commented 2024-12-25 16:22:36 +00:00
Copy link

Remove or rewrite

Remove or rewrite
src-tauri/src/lib.rs
MartinKavik (Migrated from github.com) commented 2024-12-25 16:21:41 +00:00
Copy link

Why are we waiting?

Why are we waiting?
src-tauri/src/lib.rs
MartinKavik (Migrated from github.com) commented 2024-12-25 16:21:50 +00:00
Copy link

Typo

Typo
ThePerfectComputer commented 2024-12-25 17:26:00 +00:00 (Migrated from github.com)
Copy link

I guess it's also worth noting that the terminal feature will probably not work on windows. I will have to think about an acceptable long term solution.

I guess it's also worth noting that the terminal feature will probably not work on windows. I will have to think about an acceptable long term solution.
ThePerfectComputer (Migrated from github.com) reviewed 2024-12-27 12:26:16 +00:00
src-tauri/src/lib.rs
ThePerfectComputer (Migrated from github.com) commented 2024-12-27 12:26:16 +00:00
Copy link

We wait in case the frontend starts slightly after the backend. We, don't want the frontend to miss the first term update.

We wait in case the frontend starts slightly after the backend. We, don't want the frontend to miss the first term update.
ThePerfectComputer (Migrated from github.com) reviewed 2024-12-27 15:22:35 +00:00
frontend/src/term.rs
ThePerfectComputer (Migrated from github.com) commented 2024-12-27 15:22:35 +00:00
Copy link

Fully addressing NFC vs NFD unicode behavior will open a can of worms that is non-trivial to resolve. Hopefully, most users have keyboards that input a single unicode point instead of base followed by diacritic.

Fully addressing NFC vs NFD unicode behavior will open a can of worms that is non-trivial to resolve. Hopefully, most users have keyboards that input a single unicode point instead of base followed by diacritic.
Sign in to join this conversation.
Reviewers
No reviewers
MartinKavik
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Products/FastWave2.0#19
No description provided.
Delete branch "add_term_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?