fix canvas position, dynamic layout

This commit is contained in:
Martin Kavík 2024-05-31 01:35:05 +02:00
parent fb9fd9ab78
commit 9ea952a2f5
6 changed files with 93 additions and 43 deletions

View file

@ -1,5 +1,5 @@
use crate::tauri_bridge;
use crate::HierarchyAndTimeTable;
use crate::{HierarchyAndTimeTable, Layout};
use futures_util::join;
use std::mem;
use std::ops::Not;
@ -8,13 +8,7 @@ use wellen::GetItem;
use zoon::*;
const SCOPE_VAR_ROW_MAX_WIDTH: u32 = 480;
#[derive(Clone, Copy, Default)]
enum Layout {
Tree,
#[default]
Columns,
}
const MILLER_COLUMN_MAX_HEIGHT: u32 = 500;
#[derive(Clone)]
struct VarForUI {
@ -48,12 +42,13 @@ impl ControlsPanel {
pub fn new(
hierarchy_and_time_table: Mutable<Option<HierarchyAndTimeTable>>,
selected_var_refs: MutableVec<wellen::VarRef>,
layout: Mutable<Layout>,
) -> impl Element {
Self {
selected_scope_ref: <_>::default(),
hierarchy_and_time_table,
selected_var_refs,
layout: <_>::default(),
layout,
}
.root()
}
@ -71,16 +66,25 @@ impl ControlsPanel {
fn root(&self) -> impl Element {
let triggers = self.triggers();
let layout = self.layout.clone();
let layout_and_hierarchy_signal = map_ref! {
let layout = self.layout.signal(),
let layout = layout.signal(),
let hierarchy_and_time_table = self.hierarchy_and_time_table.signal_cloned() => {
(*layout, hierarchy_and_time_table.clone().map(|(hierarchy, _)| hierarchy))
}
};
Column::new()
.after_remove(move |_| drop(triggers))
.s(Height::fill())
.s(Width::fill())
.s(Width::with_signal_self(
self.layout
.signal()
.map(|layout| matches!(layout, Layout::Columns))
.map_true(|| Width::fill()),
))
.s(Height::with_signal_self(layout.signal().map(move |layout| match layout {
Layout::Tree => Height::fill(),
Layout::Columns => Height::fill().max(MILLER_COLUMN_MAX_HEIGHT),
})))
.s(Scrollbars::both())
.s(Padding::all(20))
.s(Gap::new().y(40))
@ -254,7 +258,7 @@ impl ControlsPanel {
.s(Height::fill())
// @TODO add `width: max-content` to MoonZoon's `Width`?
.update_raw_el(|raw_el| raw_el.style("width", "max-content"))
.on_viewport_size_change(move |width, _| viewport_x.set(i32::MAX))
.on_viewport_size_change(move |_, _| viewport_x.set(i32::MAX))
.items(scopes_for_ui_in_levels.into_iter().map(|scopes_in_level| {
Column::new()
.s(Height::fill())
@ -396,7 +400,16 @@ impl ControlsPanel {
)
.on_hovered_change(move |is_hovered| hovered.set_neq(is_hovered))
.on_press(move || match layout.get() {
Layout::Tree => scope_for_ui.expanded.update(not),
Layout::Tree => {
if scope_for_ui.expanded.get() {
scope_for_ui.selected_scope_in_level.set(None);
} else {
scope_for_ui
.selected_scope_in_level
.set(Some(scope_for_ui.scope_ref));
}
scope_for_ui.expanded.update(not)
}
Layout::Columns => {
selected_scope_ref.set_neq(None);
if scope_for_ui.expanded.get() {
@ -415,7 +428,6 @@ impl ControlsPanel {
scope_for_ui: ScopeForUI,
button_hovered: Mutable<bool>,
) -> impl Element {
let layout = self.layout.clone();
Button::new()
.s(Padding::new().x(15).y(5))
.s(Font::new().wrap_anywhere())

View file

@ -11,6 +11,13 @@ use waveform_panel::WaveformPanel;
type HierarchyAndTimeTable = (Rc<wellen::Hierarchy>, Rc<wellen::TimeTable>);
#[derive(Clone, Copy, Default)]
enum Layout {
Tree,
#[default]
Columns,
}
fn main() {
start_app("app", root);
Task::start(async {
@ -23,16 +30,27 @@ fn main() {
fn root() -> impl Element {
let hierarchy_and_time_table: Mutable<Option<HierarchyAndTimeTable>> = <_>::default();
let selected_var_refs: MutableVec<wellen::VarRef> = <_>::default();
Row::new()
let layout: Mutable<Layout> = <_>::default();
Column::new()
.s(Height::fill())
.s(Scrollbars::y_and_clip_x())
.s(Font::new().color(color!("Lavender")))
.s(Gap::new().x(15))
.item(ControlsPanel::new(
.item(
Row::new()
.s(Height::fill())
.s(Gap::new().x(15))
.item(ControlsPanel::new(
hierarchy_and_time_table.clone(),
selected_var_refs.clone(),
layout.clone(),
))
.item_signal(layout.signal().map(|layout| matches!(layout, Layout::Tree)).map_true(clone!((hierarchy_and_time_table, selected_var_refs) move || WaveformPanel::new(
hierarchy_and_time_table.clone(),
selected_var_refs.clone(),
))))
)
.item_signal(layout.signal().map(|layout| matches!(layout, Layout::Columns)).map_true(move || WaveformPanel::new(
hierarchy_and_time_table.clone(),
selected_var_refs.clone(),
))
.item(WaveformPanel::new(
hierarchy_and_time_table,
selected_var_refs,
))
)))
}

View file

@ -3,7 +3,7 @@ use wellen::GetItem;
use zoon::*;
mod pixi_canvas;
use pixi_canvas::PixiCanvas;
use pixi_canvas::{PixiCanvas, PixiController};
const ROW_HEIGHT: u32 = 40;
const ROW_GAP: u32 = 4;
@ -67,7 +67,13 @@ impl WaveformPanel {
})).for_each(clone!((controller, hierarchy_and_time_table) move |vec_diff| {
clone!((controller, hierarchy_and_time_table) async move {
match vec_diff {
VecDiff::Replace { values: _ } => { todo!("`task_with_controller` + `Replace`") },
VecDiff::Replace { values } => {
let controller = controller.wait_for_some_cloned().await;
controller.clear_vars();
for var_ref in values {
Self::push_var(&controller, &hierarchy_and_time_table, var_ref).await;
}
},
VecDiff::InsertAt { index: _, value: _ } => { todo!("`task_with_controller` + `InsertAt`") }
VecDiff::UpdateAt { index: _, value: _ } => { todo!("`task_with_controller` + `UpdateAt`") }
VecDiff::RemoveAt { index } => {
@ -78,20 +84,7 @@ impl WaveformPanel {
VecDiff::Move { old_index: _, new_index: _ } => { todo!("`task_with_controller` + `Move`") }
VecDiff::Push { value: var_ref } => {
if let Some(controller) = controller.lock_ref().as_ref() {
let (hierarchy, time_table) = hierarchy_and_time_table.get_cloned().unwrap();
let var = hierarchy.get(var_ref);
let signal_ref = var.signal_ref();
let signal = tauri_bridge::load_and_get_signal(signal_ref).await;
let timescale = hierarchy.timescale();
zoon::println!("{timescale:?}");
// Note: Sync `timeline`'s type with the `Timeline` in `frontend/typescript/pixi_canvas/pixi_canvas.ts'
let mut timeline: Vec<(wellen::Time, Option<String>)> = time_table.iter().map(|time| (*time, None)).collect();
for (time_index, signal_value) in signal.iter_changes() {
timeline[time_index as usize].1 = Some(signal_value.to_string());
}
controller.push_var(serde_wasm_bindgen::to_value(&timeline).unwrap_throw());
Self::push_var(controller, &hierarchy_and_time_table, var_ref).await;
}
}
VecDiff::Pop {} => {
@ -110,6 +103,27 @@ impl WaveformPanel {
})
}
async fn push_var(
controller: &PixiController,
hierarchy_and_time_table: &Mutable<Option<HierarchyAndTimeTable>>,
var_ref: wellen::VarRef,
) {
let (hierarchy, time_table) = hierarchy_and_time_table.get_cloned().unwrap();
let var = hierarchy.get(var_ref);
let signal_ref = var.signal_ref();
let signal = tauri_bridge::load_and_get_signal(signal_ref).await;
let timescale = hierarchy.timescale();
zoon::println!("{timescale:?}");
// Note: Sync `timeline`'s type with the `Timeline` in `frontend/typescript/pixi_canvas/pixi_canvas.ts'
let mut timeline: Vec<(wellen::Time, Option<String>)> = time_table.iter().map(|time| (*time, None)).collect();
for (time_index, signal_value) in signal.iter_changes() {
timeline[time_index as usize].1 = Some(signal_value.to_string());
}
controller.push_var(serde_wasm_bindgen::to_value(&timeline).unwrap_throw());
}
fn selected_var_panel(
&self,
index: ReadOnlyMutable<Option<usize>>,

View file

@ -1,4 +1,5 @@
use zoon::*;
pub use js_bridge::PixiController;
pub struct PixiCanvas {
raw_el: RawHtmlEl<web_sys::HtmlElement>,
@ -89,6 +90,7 @@ mod js_bridge {
// Note: Add all corresponding methods to `frontend/typescript/pixi_canvas/pixi_canvas.ts`
#[wasm_bindgen(module = "/typescript/bundles/pixi_canvas.js")]
extern "C" {
#[derive(Clone)]
pub type PixiController;
// @TODO `row_height` and `row_gap` is FastWave-specific

View file

@ -35161,7 +35161,9 @@ var PixiController = class {
}
// -- FastWave-specific --
remove_var(index) {
this.var_signal_rows[index].destroy();
if (typeof this.var_signal_rows[index] !== "undefined") {
this.var_signal_rows[index].destroy();
}
}
push_var(timeline) {
new VarSignalRow(
@ -35174,7 +35176,7 @@ var PixiController = class {
);
}
pop_var() {
this.var_signal_rows[this.var_signal_rows.length - 1].destroy();
this.remove_var(this.var_signal_rows.length - 1);
}
clear_vars() {
this.var_signal_rows.slice().reverse().forEach((row) => row.destroy());

View file

@ -46,7 +46,9 @@ export class PixiController {
// -- FastWave-specific --
remove_var(index: number) {
this.var_signal_rows[index].destroy();
if (typeof this.var_signal_rows[index] !== 'undefined') {
this.var_signal_rows[index].destroy();
}
}
push_var(timeline: Timeline) {
@ -61,7 +63,7 @@ export class PixiController {
}
pop_var() {
this.var_signal_rows[this.var_signal_rows.length - 1].destroy();
this.remove_var(this.var_signal_rows.length - 1);
}
clear_vars() {